feat: Support spaces between field name and value #2678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkheir
force-pushed
the
feat/query_grammar_space_between_field_and_value
branch
from
fd0896d to
d4b0901
Compare
|
@trinity-1686a can you review? Does it looks sound? |
trinity-1686a
approved these changes
Aug 1, 2025
|
Thank you for the review :) I added few tests, but don't hesitate to ask for more if you see some edge cases that could not be covered by the existing ones. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow optional spaces between the field name and the value the same way Lucene allows them