Prevent db locking when multiple queries from quay are accessing same tables (PROJQUAY-8758) #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ROJQUAY-8758) Signed-off-by: harishsurf <[email protected]>
harishsurf
added
ok-to-test
harishsurf
added
ok-to-test
harishsurf
added
ok-to-test
harishsurf
added
ok-to-test
harishsurf
added
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
PRAGMA journal_mode=WALto the quay's sqlite file to improve speed and reduce lock contention in multi-access scenarios.Testing:
Ran
oc mirror, during mirroring delete the repo being mirrored. Repository GC worker tries to clean up the repo while the mirroring is also writing to the repo. Since both processes are in contention to write to the same table, sqlite throws database is locked. This error is not seen in after setting the database to WAL