Skip to content

Conversation

@SamVanini
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

This PR aims to solve the violation of [WCAG Success Criterion 4.1.2: Name, Role, Value (Level A)], adding aria-label attributes to pagination button.

I translated the required labels in all the supported languages, but I am not sure about the correctness of every single one, speaking myself only Italian, English and a bit of German.

Fixes #17148

@yusufkandemir yusufkandemir changed the title fix(ui): Added aria-label to table paginator buttons, managed labels internationalization #17148 fix(ui): add aria-label to table pagination buttons (fix: #17148) Feb 24, 2025
@yusufkandemir yusufkandemir added the area/a11y Accessibility label Feb 24, 2025
@yusufkandemir
Copy link
Member

This is great, thanks! When I have time, I will implement the requested changes and merge this PR.

@SamVanini
Copy link
Contributor Author

I tried to implement the requested changes to the pagination component @yusufkandemir.
If you think that it could be written in a better or cleaner way I am open to suggestions and your feedback would be very much appreciated.

Thanks in advance for the review!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs the ariaLabels approach with appropriate reversing, as you did in QPagination

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused, I think icons get swapped for visuals, but the logic stays the same. I think the same applies to QPagination as well. Did you test both accordingly?

rstoenescu and others added 3 commits February 27, 2025 14:47
Co-authored-by: Yusuf Kandemir <[email protected]>
Co-authored-by: Yusuf Kandemir <[email protected]>
Co-authored-by: Yusuf Kandemir <[email protected]>
@rstoenescu rstoenescu merged commit 8f4ffd1 into quasarframework:dev Feb 27, 2025
@rstoenescu
Copy link
Member

Thanks for the awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/a11y Accessibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Labels for QTable Pagination Buttons

4 participants