-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(ui): add aria-label to table pagination buttons (fix: #17148) #17809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): add aria-label to table pagination buttons (fix: #17148) #17809
Conversation
|
This is great, thanks! When I have time, I will implement the requested changes and merge this PR. |
|
I tried to implement the requested changes to the pagination component @yusufkandemir. Thanks in advance for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs the ariaLabels approach with appropriate reversing, as you did in QPagination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got confused, I think icons get swapped for visuals, but the logic stays the same. I think the same applies to QPagination as well. Did you test both accordingly?
Co-authored-by: Yusuf Kandemir <[email protected]>
Co-authored-by: Yusuf Kandemir <[email protected]>
Co-authored-by: Yusuf Kandemir <[email protected]>
|
Thanks for the awesome work! |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This PR aims to solve the violation of [WCAG Success Criterion 4.1.2: Name, Role, Value (Level A)], adding aria-label attributes to pagination button.
I translated the required labels in all the supported languages, but I am not sure about the correctness of every single one, speaking myself only Italian, English and a bit of German.
Fixes #17148