Skip to content

Conversation

@jclaveau
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No => I guess not bluring a non focused q-focus-helper is not a breaking change

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app

This looks cumbersome to test as we need human fingers to get e.isTrusted === true

  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Like in this PR #17802, without it I can't switch the color picker tabs while keeping the focus / selection on my contenteditable (Considering the fact I prevent / stop the user event and replace it by a new MouseEvent('click') )

Other information:

@github-actions
Copy link

UI Tests Results

    1 files     98 suites   38s ⏱️
1 031 tests 1 031 ✅ 0 💤 0 ❌
1 050 runs  1 050 ✅ 0 💤 0 ❌

Results for commit a40c594.

rstoenescu added a commit that referenced this pull request Mar 1, 2025
@rstoenescu
Copy link
Member

I think it's better to avoid relying on isTrusted due to the many environments that we support & because we actually want a certain behavior. Pushed a commit that avoids focusing when evt.qAvoidFocus flag is set to true. This is better for code readability and the intent is clear. Will be available in Quasar v2.18.0

@rstoenescu rstoenescu closed this Mar 1, 2025
@rstoenescu
Copy link
Member

And, of course, thank you for taking time for a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants