Improvement of instructions to verify OpenShift deployment #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josequaresma sorry for not replying earlier. In fact the reference files for the guides are in the main repo here: https://github.com/quarkusio/quarkus/tree/master/docs/src/main/asciidoc and are synced when we release (I added a warning at the top of the files for the next release). Could you submit your PR there? I'll apply it right away? We release a new version tomorrow so if I can merge it by then, it will be in the next release. |
|
Ah! Sorry for mixing it up @gsmet . Will submit the PR there in a couple of hours |
|
Yeah, it was not very clear until now, hopefully the message at the top will help (it will be deployed tomorrow). Thanks! |
|
@gsmet PR (hopefully the right one now) created here quarkusio/quarkus#1823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following command wasn't working
curl $URL/hello/quarkussince it requires/hello/greeting/quarkus. I have updated that and have done two other small changes to make the output a bit more friendly