Skip to content

Fix NullPointerException(s) when dealing with remote and local address returned by HTTP request #9935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fix NullPointerException(s) when dealing with remote and local address returned by HTTP request #9935

merged 1 commit into from
Jun 11, 2020

Conversation

@jaikiran
Copy link
Member

@jaikiran jaikiran commented Jun 11, 2020

Fixes #9882

Both localAddress and remoteAddress of io.vertx.core.http.HttpServerRequest as per the javadoc can return null in certain cases. The commit here adds a check to make sure we don't run into NullPointerException when using these attribute values in access logging

@jaikiran jaikiran requested a review from stuartwdouglas June 11, 2020 04:19
@gastaldi gastaldi added this to the 1.6.0 - master milestone Jun 11, 2020
@gsmet gsmet merged commit d2bcc97 into quarkusio:master Jun 11, 2020
@jaikiran jaikiran deleted the qk-9882 branch June 11, 2020 08:17
@gsmet gsmet modified the milestones: 1.6.0 - master, 1.5.1.Final Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/vertx

Projects

None yet

Milestone

1.5.1.Final

Development

Successfully merging this pull request may close these issues.

NullPointerException when quarkus.http.access-log.enabled=true

4 participants

@jaikiran @stuartwdouglas @gastaldi @gsmet