If the rotate-on-boot is defined and there is a file-suffix use the PeriodicSizeRotatingFileHandler #9670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the PeriodicSizeRotatingFileHandler. Fixes quarkusio#9259
dmlloyd
approved these changes
Jun 2, 2020
|
How about extending https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/logging/FileConfig.java#L76 so that it is clear that the suffix has to be set to make it work? |
gsmet
changed the title
|
I pushed 2 additional commits related to docs. I agree with @famod having a mention of how it works is worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e the PeriodicSizeRotatingFileHandler.
Note it was a conscious decision not to allow the
SizeRotatingFileHandlerif therotate-on-bootwas defined, butmax-file-sizewas not. That seems like an odd use case as we'd have to assume some kind of maximum size. This could beLong.MAX_VALUE, but again that seems odd.Also if this needs to be ported to the other branches let me know and I'm happy to do it.
Fixes #9259