Cache doc improvement to better describe behaviors #9659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Lets let @gwenneg who wrote this review it |
|
Thanks @gwenneg for your review and suggestions. They make sense so I committed them. Hope this is correct process and you can merge PR now. |
Cache doc improved with: * info that equals() and hashCode() is important if part of key is object * info about default behavior of the cache which is not configured
|
I force pushed a squash. @gwenneg I let you approve and merge if you think it's all good. Thanks! |
|
Thanks a lot all for your help with my first contribution to Quarkus. 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache doc improved with: