Rename credentials-provider-type into credentials-provider-name

[vsevel]

Follow up to #9552 and this specific #9552 (comment)
Rename credentials-provider-type into credentials-provider-name.
Discuss whether the existing name should be renamed into id.

/cc @sberyozkin @geoand

[geoand]

Seems reasonable to me ( obviously since I'm the one that originally brought it up 😆 )

[vsevel]

Seems reasonable to me ( obviously since I'm the one that originally brought it up 😆 )

sure ;)

just to challenge before we close it, I think we should rename the credentials provider name to id or alias, so that we do not confuse it with the credentials provider bean name. I could see people getting very confused (if type did not speak to you, at least it was different from name).
what do you think @geoand ?

[geoand]

Yeah, that makes sense to me. @sberyozkin WDYT?

[gsmet]

Let's go with it. It's better than before.

[gsmet]

I will backport it.

[vsevel]

Let's go with it. It's better than before.

the good news is that if we want to go ahead and rename the name field to id, this won't be a breaking change. let me know if you think it is worthwhile. otherwise I will keep it as is.