Skip to content

Conversation

@gsmet
Copy link
Member

@gsmet gsmet commented May 25, 2020

PLEASE DON'T MERGE AS MAYBE LUIS WILL COME WITH A QUICK RELEASE BEFORE I RELEASE FINAL

(and I don't use WIP as I want a proper CI run)

This reverts commit bd3016c.

1.8 introduces a log message at each startup:
2020-05-21 16:35:10,006 INFO [io.agr.pool] (main) Datasource '': Pool interceptors: []

While not a big issue, it's definitely a usability regression
consisdering we are working hard on keeping our logs as less verbose as
possible.

I think we should demote this log message to DEBUG.

/cc @barreiro

This reverts commit bd3016c.

1.8 introduces a log message at each startup:
2020-05-21 16:35:10,006 INFO [io.agr.pool] (main) Datasource '<default>': Pool interceptors: []

While not a big issue, it's definitely a usability regression
consisdering we are working hard on keeping our logs as less verbose as
possible.

I think we should demote this log message to DEBUG.
@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label May 25, 2020
@machi1990
Copy link
Member

1.8 introduces a log message at each startup:
2020-05-21 16:35:10,006 INFO [io.agr.pool] (main) Datasource '': Pool interceptors: []

While not a big issue, it's definitely a usability regression
consisdering we are working hard on keeping our logs as less verbose as
possible.

Was filtering out the log instead with a build item considered?

@gsmet
Copy link
Member Author

gsmet commented May 25, 2020

That could have been a good idea but the start of the message (before you get the database name) is not easily identifiable unfortunately. And we don't use regexps, we compare the start of the message.

That's why I passed on this option.

@machi1990
Copy link
Member

That could have been a good idea but the start of the message (before you get the database name) is not easily identifiable unfortunately. And we don't use regexps, we compare the start of the message.

That's why I passed on this option.

Could have been a good fix till an upstream release. Thanks for answering / looking.

@gsmet
Copy link
Member Author

gsmet commented May 26, 2020

Superseded by #9596 .

@gsmet gsmet closed this May 26, 2020
@gsmet gsmet added triage/invalid This doesn't seem right and removed triage/backport? labels May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Pull requests that update a dependency file triage/invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants