Set LogManager for all failsafe executions #9557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/dependencies
geoand
approved these changes
May 24, 2020
Contributor
geoand
left a comment
geoand
left a comment
There was a problem hiding this comment.
LGTM. Lets see if @aloubyansky agrees
aloubyansky
approved these changes
May 24, 2020
Member
|
@aloubyansky please don't add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my last PR before the introduction of the system property
maven.homein #9523.I thought it would make sense to have a consistent state of surefire and failsafe.
I almost went as far as pulling out
from all the
integration-testsmodules (moving it tobuild-parent) but I wasn't sure whether you guys would like that.Maybe the two goals could also be "pulled up", later.
cc @geoand @aloubyansky