Skip to content

Conversation

@oscerd
Copy link
Contributor

@oscerd oscerd commented May 22, 2020

No description provided.

@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label May 22, 2020
@oscerd
Copy link
Contributor Author

oscerd commented May 22, 2020

@gsmet

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, want to add it to dependabot?

@oscerd
Copy link
Contributor Author

oscerd commented May 22, 2020

Yeah, I noticed this because It was updated on Apache Camel too.

@gastaldi gastaldi added this to the 1.5.0.Final milestone May 22, 2020
@gastaldi gastaldi merged commit ca3ee38 into quarkusio:master May 22, 2020
@gsmet gsmet removed this from the 1.5.0.Final milestone May 25, 2020
@gsmet
Copy link
Member

gsmet commented May 25, 2020

@gastaldi please don't add the 1.5.0.Final version and add the backport tag. Otherwise this won't be backported to 1.5 and we will miss it.

Thanks.

@gastaldi
Copy link
Contributor

Ah, so PRs that should be backported don't get a version now? That's news to me.

Thanks for the heads up.

@gsmet
Copy link
Member

gsmet commented May 25, 2020

That's not new. You can set a version but it should be the one of master so currently 1.6.0 (see my email on quarkus-dev).

But it should never be the branched release as, once merged, the PR is not magically there, I need to backport it thus the label.

So feel free to add 1.6.0, I change the milestone when backporting and so when the commits are really in the branch.

@gastaldi
Copy link
Contributor

gastaldi commented May 25, 2020

For some reason I assumed 1.5.0 to be master. Can we have some kind of marker in the milestone version to indicate that it is master?

@gastaldi gastaldi added this to the 1.6.0 milestone May 25, 2020
@gsmet gsmet modified the milestones: 1.6.0 - master, 1.5.0.Final May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants