Make access logging work in native mode #9474
Conversation
| if (serviceInterfaceClassName == null || serviceInterfaceClassName.trim().isEmpty()) { | ||
| throw new IllegalArgumentException("service interface name cannot be null or blank"); | ||
| } | ||
| final ClassLoader classLoaderToUse = cl == null ? Thread.currentThread().getContextClassLoader() : cl; |
There was a problem hiding this comment.
An issue with this approach is that if there are additional service implementations on the deployment class path that are not on the runtime class path this will cause failures. Not sure how likely this in practice.
There was a problem hiding this comment.
You are right. I hadn't thought of this scenario. I think I might have a slightly different way to achieve this same functionality without having to run into the issue that you note here. I'll try it out and update the PR shortly.
...vertx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/VertxHttpProcessor.java
Outdated
Show resolved
Hide resolved
…ttributeBuilder service providers for access logging to work in native image
|
Hello @stuartwdouglas, given that the goal of this change was to register the "core" |
|
Thanks Jaikiran |
|
thx guys for working on this issue |
4 participants
Fixes #9047
Right now, access logging isn't working in native mode as reported in the issue. This is because the
ExchangeAttributeBuilder(s) which are responsible for handling the access log format specifier areServiceLoaderbased interfaces and as such need to be explicitly registered in native image for them to be available.The commit here explicitly makes them available in native mode and also includes a test to reproduce the issue and verify the fix.