Skip to content

Conversation

@stuartwdouglas
Copy link
Collaborator

…r from Spring Boot.

This reverts commit 7c9face.

This caused CI failures and was reverted, even though the run was green. Reopened here to get more info on the failures.

@boring-cyborg boring-cyborg bot added area/core area/dependencies Pull requests that update a dependency file area/documentation labels May 20, 2020
@gsmet
Copy link
Member

gsmet commented May 20, 2020

FWIW, the issue I had in CI was 404 similar to what we had before all the fixes you made.

@stuartwdouglas
Copy link
Collaborator Author

Initial run was green, I have rebased to try capture the problem. @gsmet I don't suppose you have a link to one of the failures?

@gsmet
Copy link
Member

gsmet commented May 21, 2020

No I don't. There wasn't much info, just 404s when trying to get the webjar resources.

@Christopher-Chianelli
Copy link
Contributor

Here a run for an integration test that failed after the PR was merged and before it was reverted: https://github.com/quarkusio/quarkus/runs/688607249 (commit e007fe5) (also fails for Windows: https://github.com/quarkusio/quarkus/runs/688607008)

@stuartwdouglas
Copy link
Collaborator Author

well it seems to be fine now, it has passed with no failures at all 3 times in a row. Looking at the time frame between when it was merged and reverted it looks like it was when CI was completely screwed anyway as quay.io was down?

@gsmet
Copy link
Member

gsmet commented May 25, 2020

The errors I had were absolutely not related to the quay.io outage. It was 404s on the resources handled by the webjar locator. That's why I reverted it, I didn't pick a PR randomly :).

We can try merging it again though and see how it goes.

@stuartwdouglas
Copy link
Collaborator Author

I am re-running CI again.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and see how it goes.

@gsmet gsmet merged commit 1d5e197 into quarkusio:master May 26, 2020
@gsmet gsmet added this to the 1.6.0 milestone May 26, 2020
@gsmet gsmet changed the title Add a WebJar Locator extension that duplicates webjar locator behavio… Add a WebJar Locator extension that duplicates webjars locator behavior Jul 6, 2020
@gsmet gsmet changed the title Add a WebJar Locator extension that duplicates webjars locator behavior Add a WebJars Locator extension that duplicates webjars locator behavior from Spring Boot Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants