- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3k
 
Add a WebJars Locator extension that duplicates webjars locator behavior from Spring Boot #9473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           FWIW, the issue I had in CI was 404 similar to what we had before all the fixes you made.  | 
    
cf13f3e    to
    7f551e4      
    Compare
  
    | 
           Initial run was green, I have rebased to try capture the problem. @gsmet I don't suppose you have a link to one of the failures?  | 
    
| 
           No I don't. There wasn't much info, just 404s when trying to get the webjar resources.  | 
    
| 
           Here a run for an integration test that failed after the PR was merged and before it was reverted: https://github.com/quarkusio/quarkus/runs/688607249 (commit e007fe5) (also fails for Windows: https://github.com/quarkusio/quarkus/runs/688607008)  | 
    
7f551e4    to
    2f0f1b9      
    Compare
  
    | 
           well it seems to be fine now, it has passed with no failures at all 3 times in a row. Looking at the time frame between when it was merged and reverted it looks like it was when CI was completely screwed anyway as quay.io was down?  | 
    
| 
           The errors I had were absolutely not related to the quay.io outage. It was 404s on the resources handled by the webjar locator. That's why I reverted it, I didn't pick a PR randomly :). We can try merging it again though and see how it goes.  | 
    
…r from Spring Boot. This reverts commit 7c9face.
2f0f1b9    to
    c06a9ac      
    Compare
  
    | 
           I am re-running CI again.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and see how it goes.
…r from Spring Boot.
This reverts commit 7c9face.
This caused CI failures and was reverted, even though the run was green. Reopened here to get more info on the failures.