Skip to content

Conversation

@jaikiran
Copy link
Member

Fixes #9295

The "%r" format specifier used by the common access log implies the request line. The implementation in RequestLineAttribute currently uses exchange.request().uri() which includes both the request path and query params (the javadoc of that io.vertx.core.http.HttpServerRequest.uri() doesn't explain much of what to expect of the return value but at least the implementation returns both the path and the query params. So there's no need to additionally append the query params explicitly. The commit in this PR fixes that and includes a test to reproduce the issue and verify the fix.

@joan-miralles
Copy link

What about if the URL contains some character like #? What's the behaviour of the io.vertx.core.http.HttpServerRequest.uri()?

Thanks!

@jaikiran
Copy link
Member Author

The # is a client side construct. It's never sent to the server.

@cescoffier
Copy link
Member

@gsmet this one could be merged before the cut. Harmless.

@gsmet gsmet added this to the 1.5.0.CR1 milestone May 19, 2020
@gsmet gsmet merged commit c06ab1d into quarkusio:master May 19, 2020
@gsmet
Copy link
Member

gsmet commented May 19, 2020

Merged, thanks!

@joan-miralles
Copy link

Thanks a lot!

@jaikiran jaikiran deleted the qk-9295 branch May 20, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default quarkus.http.access-log.pattern "common" duplicate query_string

4 participants