Amazon KMS + SES extensions #9413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/core
area/dependencies
|
Hopefully, this makes it in 1.5! |
gsmet
requested changes
May 20, 2020
|
I might not have it ready by Tuesday. So 1.6 seems more realistic
śr., 20 maj 2020, 10:01 użytkownik Guillaume Smet <[email protected]>
napisał:
… ***@***.**** requested changes on this pull request.
Looks good to me, thanks! Do you think you will be able to write the
guides before next Tuesday? Just to know if we should target 1.5 or push
this to 1.6.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9413 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAF4G2BJFMWRTYNIHBJPEDRSOE43ANCNFSM4NEEAKXQ>
.
|
gsmet
reviewed
May 25, 2020
| - name: Amazon Services | ||
| run: | | ||
| docker run --rm --publish 8000:4569 --publish 8008:4572 --publish 8009:4575 --publish 8010:4576 --name build-amazon-service-clients -e SERVICES=s3,dynamodb,sns,sqs -e START_WEB=0 \ | ||
| docker run --rm --publish 8000:4569 --publish 8008:4572 --publish 8009:4575 --publish 8010:4576 --publish 8011:4599 --publish 8012:4566 --name build-amazon-service-clients -e SERVICES=s3,dynamodb,sns,sqs,kms,ses -e START_WEB=0 \ |
There was a problem hiding this comment.
You probably need to make the timeout for the Amazon services native job higher. It's 20 right now, maybe make it 30.
There was a problem hiding this comment.
Yep, i noticed that
10 tasks
marcinczeczko
force-pushed
the
amazon-kms-ses
branch
from
1d66346 to
b9a4301
Compare
|
@gsmet - I managed to produce guides and quickstart. |
|
OK, I will merge that one and backport. I will probably tweak the guides a bit later if I have some time. Thanks for the quick turnaround! |
gsmet
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon KMS (key management service) + SES (Simple email service) extensions