Windows fix for fast-jar #9365
Merged
Windows fix for fast-jar #9365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this got lost in a rebase
boring-cyborg
bot
added
the
area/devtools
aloubyansky
reviewed
May 16, 2020
| String path = QuarkusEntryPoint.class.getProtectionDomain().getCodeSource().getLocation().getPath(); | ||
| String decodedPath = URLDecoder.decode(path, "UTF-8"); | ||
| SerializedApplication app = SerializedApplication.read(in, Paths.get(decodedPath).getParent().getParent()); | ||
| SerializedApplication app = SerializedApplication.read(in, new File(decodedPath).toPath().getParent().getParent()); |
There was a problem hiding this comment.
Did this make a difference?
There was a problem hiding this comment.
This is the most important bit. new File and Paths.get() behave differently when passed a windows path
|
This seems to be passing the Windows tests while most other PRs are failing, so I'll go ahead and merge |
geoand
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this got lost in a rebase