Skip to content

Scope permission checks may result in a false positive #9098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2020
Merged

Scope permission checks may result in a false positive #9098

merged 2 commits into from
Jun 3, 2020

Conversation

@pedroigor
Copy link
Contributor

@pedroigor pedroigor commented May 5, 2020 •
edited by gsmet
Loading

@sberyozkin
Copy link
Member

Hey @pedroigor, thanks for the fast fix, we have a PR pending to get KC 10.0.0 supported, but will we have to wait till KEYCLOAK-14076 is fixed before we can merge this PR ?

@pedroigor
Copy link
Contributor Author

Yes, it should be there for Keycloak 11.0.0.

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/oidc labels Jun 2, 2020
@pedroigor
Copy link
Contributor Author

@sberyozkin Here are your changes to upgrade Keycloak version as well as those for keycloak-authorization extension.

@pedroigor pedroigor requested a review from sberyozkin June 2, 2020 20:51
@sberyozkin
Copy link
Member

@pedroigor Hi Pedro, sorry, I missed it yesterday, thanks for picking up some of the changes from the draft PR

@sberyozkin sberyozkin added this to the 1.6.0 - master milestone Jun 3, 2020
@sberyozkin
Copy link
Member

@gsmet I'm adding a backport label just in case 1.5.1 will be planned, please ignore it otherwise, thanks

@sberyozkin sberyozkin merged commit 5b4683d into quarkusio:master Jun 3, 2020
@pedroigor pedroigor deleted the issue-9057 branch June 3, 2020 12:01
@gsmet gsmet modified the milestones: 1.6.0 - master, 1.5.1.Final Jun 10, 2020
@gsmet gsmet changed the title [fixes #9057] - Scope permission checks may result in a false positive Scope permission checks may result in a false positive Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees

No one assigned

Labels

area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/keycloak-authorization area/oidc area/security

Projects

None yet

Milestone

1.5.1.Final

Development

Successfully merging this pull request may close these issues.

Keycloak authorization: issue with the scopes and permissions

3 participants

@pedroigor @sberyozkin @gsmet