Amazon Lambda deployment check for abstract handler #9023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaikiran
reviewed
May 2, 2020
...mbda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java
Outdated
Show resolved
Hide resolved
|
Nice one thanks! I googled and couldn’t work out how to do it with Jandex, much appreciated for the tip. I’ll make the necessary changes. |
There isn't much info on Jandex in the usual sources, so feel free to ask since it's the easiest way to get a proper answer. |
oztimpower
force-pushed
the
ext/aws-lambda-8964
branch
from
e5ff491 to
322f2ee
Compare
gsmet
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #8964, it was noted that an abstract implementation of RequestHandler<I, O> is not detected.
Modify the deployment to check if the handler is abstract.
Tested by:
/cc @patriot1burke