Skip to content

Conversation

@paulkmoore
Copy link
Contributor

Fixes #8915

@sberyozkin
Copy link
Member

Hi @paulkmoore This reads very well, thanks, the only thing I'd like to ask for is to remove a link to JsonWebToken and refer to it either simply as JsonWebToken (package name is in the code fragment) or as org.eclipse.microprofile.jwt.JsonWebToken.
The master version, though not in the short term, may be different to what is offered in a current version of Quarkus. we can link to MP JWT 1.1.1 tag but then we'll likely forget to update the link once we move to MP JWT 2.0 for example :-)

@sberyozkin
Copy link
Member

Hi @paulkmoore Nearly ready to go, please squash.

@paulkmoore
Copy link
Contributor Author

Hi @sberyozkin Should be ready to go :)

@sberyozkin sberyozkin self-requested a review April 30, 2020 09:56
@sberyozkin sberyozkin merged commit df0a02c into quarkusio:master Apr 30, 2020
@gsmet gsmet modified the milestone: 1.4.2.Final Apr 30, 2020
@paulkmoore paulkmoore deleted the dev branch May 1, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Injection of JWT available in OIDC implementation

3 participants