Skip to content

Qute - get rid of VariantTemplate and unify func. of injected templates #8824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2020
Merged

Qute - get rid of VariantTemplate and unify func. of injected templates #8824

merged 1 commit into from
Apr 25, 2020

Conversation

@mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 24, 2020

@mkouba mkouba requested a review from FroMage April 24, 2020 12:26
@mkouba mkouba added this to the 1.5.0 milestone Apr 24, 2020
FroMage
FroMage approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsmet
Copy link
Member

gsmet commented Apr 25, 2020

@mkouba could you add something here: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.5 ?

@gsmet gsmet merged commit 1cafe49 into quarkusio:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FroMage FroMage FroMage approved these changes

Assignees

No one assigned

Labels

area/documentation area/qute The template engine area/resteasy-classic release/breaking-change

Projects

None yet

Milestone

1.5.0.CR1

Development

Successfully merging this pull request may close these issues.

Qute: why VariantTemplate?

3 participants

@mkouba @gsmet @FroMage