Skip to content

Conversation

@aloubyansky
Copy link
Member

The content is a bit out of date now.

  • we do not require an existing pom.xml to run create-extension;
  • I couldn't get the proposed test to pass (although I could build the extension skipping the tests and use it in an app);
  • I am not sure what the debugging chapter is suggesting, tbh. We also do not support dev mode for extension projects;
  • quarkus-platform-bom does not exist yet.

@gsmet gsmet force-pushed the greeting-extension-fixes branch from f295665 to 0bf8022 Compare April 23, 2020 08:06
* an IDE
* JDK 1.8+ installed with `JAVA_HOME` configured appropriately
* Apache Maven 3.6.2+
* Apache Maven {maven-version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the variable.


* less than 30 minutes
* an IDE
* JDK 1.8+ installed with `JAVA_HOME` configured appropriately
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it back to 1.8+ as we are still supporting 1.8 and all the other guides reference 1.8. Better update them all at once (and make it a variable in passing).

@gsmet gsmet merged commit 575dbcc into quarkusio:master Apr 23, 2020
@gsmet gsmet added this to the 1.5.0 milestone Apr 23, 2020
@gsmet gsmet modified the milestones: 1.5.0, 1.4.0.Final, 1.4.1.Final Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants