Add test closure and configure the logging manager so log levels are considered on tests #8594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/devtools
Contributor
Author
|
Can someone help me with this cancelled check, please? |
Contributor
Author
|
Anyone? |
Member
|
Don't worry about the cancelled job, it's just an unrelated timeout. Could you squash your PR into 1 commit? @aloubyansky @glefloch could you have a look to that one? Seems to make sense but not familiar with Gradle. |
aloubyansky
approved these changes
Apr 24, 2020
Member
|
Too late but. LGTM too! |
Member
|
Thanks @oscarfh ! |
Contributor
Author
|
Thanks a lot! |
gsmet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this issue where log levels were not being considered on tests #8574
And I found this issue: #2491 where a solution is shown.
It seems that this solution is already incorporated on the pom file generated in code.quarkus.io, but not on the build.gradle file.
This PR aims to add this entry to the build.gradle file so the defined log level is considered in tests, just like this is done in the maven file.
I am not aware of the process required to get this merged. I expect the tests to run when I open this PR, but if I forgot something, please let me know