Fixed caffeine graal package name / location #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hum, wondering how could this happen? |
|
So, I checked and the funny thing is that the Maven compiler plugin doesn't throw any error or warning. So either you get the error in your IDE or you don't. |
|
ah right as package names don't actually need to match the directory path.
so I guess this didn't break the build?
…On Mon, Feb 4, 2019 at 11:43 AM Guillaume Smet ***@***.***> wrote:
So, I checked and the funny thing is that the Maven compiler plugin
doesn't throw any error or warning.
So either you get the error in your IDE or you don't.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#744 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACmTUTuWVFUgiyD28cyImXK6Ed7UUT4ks5vKA7CgaJpZM4ag1te>
.
|
Nope. I can for sure confirm that, considering how many builds I ran this week-end :). |
maxandersen
added a commit
to maxandersen/quarkus
that referenced
this pull request
Nov 5, 2022
…quarkusio#744)f //SOURCE missingfile.java will now error. //SOURCE **/*.java and it matches symoblic link which point to dead file will be ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build.