Fix NPEs in some cases in Arc #679
Conversation
There was a problem hiding this comment.
I think in this particular case we should rather modify org.jboss.shamrock.vertx.VertxProcessor.registerBean() to use unremovable additional bean, just like this: new AdditionalBeanBuildItem(false, VertxProducer.class).
There was a problem hiding this comment.
Perhaps. ATM I'm using the unremovable bean step in the project that uses VertxProducer using programmatic injection. On the basis that it's a injector-project problem rather than a producer-project problem, but perhaps that's wrong? What should be our policy?
There was a problem hiding this comment.
I'm not quite sure. But in this particular case if there is no bean injecting VertxProducer or Vertx then vertx does not even start which is IMHO not the intention.
There was a problem hiding this comment.
Ah, good point. Here the extension should just start vertx regardless of whether it's injected. If you don't want it, you don't depend on it. OTOH is it the case of other extensions? Is Hibernate or JAX-RS started if I depend on it but have no entity or rest resource?
There was a problem hiding this comment.
Is Hibernate or JAX-RS started if I depend on it but have no entity or rest resource?
I think that JAX-RS does not start: https://github.com/jbossas/protean-shamrock/blob/master/extensions/jaxrs/deployment/src/main/java/org/jboss/shamrock/jaxrs/JaxrsScanningProcessor.java#L356
I'm not sure about hibernate though.
4 participants
Part of the fixes you gave me, unrelated to Panache