Skip to content

Conversation

starksm64
Copy link
Contributor

This PR addresses the #431 issue

Note that a release of the https://github.com/jbossas/protean-wildfly-elytron-embedded project. I have made one, but I was only able to close the staging repo. Someone with more permissions will have to release it:

https://repository.jboss.org/nexus/content/repositories/jboss_releases_staging_profile-14831

Copy link
Collaborator

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just a few minor issues

@starksm64
Copy link
Contributor Author

Ok, I'll go through these.

@starksm64
Copy link
Contributor Author

With the ecea312, this should build against the released org.wildfly.security:wildfly-elytron-embedded 1.8.0.Alpha1 version. I'm now building cleanly without a local build of wildfly-elytron-embedded.

@stuartwdouglas stuartwdouglas dismissed their stale review January 24, 2019 08:53

Issues have been addressed

@stuartwdouglas stuartwdouglas merged commit 7f79a4e into quarkusio:master Jan 24, 2019
@cescoffier cescoffier added this to the 0.8.0 milestone Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants