Skip to content

Conversation

gwenneg
Copy link
Member

@gwenneg gwenneg commented Dec 13, 2019

Fixes #6127

I'm submitting this as a draft to see if CI is happy with is (even if there's no reason it wouldn't). In the meantine, I'm just starting a full JDK 11 Quarkus native build locally to make sure the exception is gone for good and see if there's anything left to fix apart from the ConcurrentModificationException.

@gwenneg gwenneg added the env/graalvm-java11 Relating to using GraalVM native image generation on Java 11 label Dec 13, 2019
@gwenneg gwenneg force-pushed the issue-6127-jdk11-graalvm-bootloader-loadclassornull-npe branch from 5e82e38 to 19adf1a Compare December 13, 2019 22:04
@gwenneg
Copy link
Member Author

gwenneg commented Dec 14, 2019

The GraalVM issue seems to be fixed, but I got two quarkus-integration-test-spring-data-jpa tests failures:

[ERROR] Failures: 
[ERROR]   PersonResourceTest.testJoinedAfter:178 1 expectation failed.
JSON path size() doesn't match.
Expected: is <0>
  Actual: 2

[ERROR]   PostResourceTest.testByPostedAtBefore:40 1 expectation failed.
JSON path size() doesn't match.
Expected: is <3>
  Actual: 0

[INFO] 
[ERROR] Tests run: 60, Failures: 2, Errors: 0, Skipped: 0

@geoand
Copy link
Contributor

geoand commented Dec 14, 2019

@gwenneg the PR seems to be OK now, did you just restart the tests?

@gwenneg
Copy link
Member Author

gwenneg commented Dec 14, 2019

The quarkus-integration-test-spring-data-jpa tests were successful after a second attempt. The failures were probably a consequence of my computer being super slow because of the full Quarkus native build.

@gwenneg gwenneg marked this pull request as ready for review December 14, 2019 09:13
@geoand
Copy link
Contributor

geoand commented Dec 14, 2019

OK cool, thanks for the info @gwenneg

@gwenneg
Copy link
Member Author

gwenneg commented Dec 14, 2019

I found one native build error unrelated to this PR, I'll check if there's already an issue opened about it and create a new one if not. This PR is ready to be reviewed and merged.

@geoand
Copy link
Contributor

geoand commented Dec 14, 2019

It looks perfectly reasonable to me but I haven't been following the latest GraalVM developments so I'll let others review and merge

@jaikiran
Copy link
Member

On a slightly unrelated note, I think we will need a issue created to rollback/undo some of these Graal VM fixes within our Quarkus code, once these fixes come in directly from Graal VM 19.3.1 (or better still a CR of 19.3.1) release.

@gsmet
Copy link
Member

gsmet commented Dec 15, 2019

@gwenneg can you open an issue with the list of the PRs that we will need to revert?

Thanks!

@gsmet gsmet merged commit 37f62ac into quarkusio:master Dec 15, 2019
@gsmet gsmet added this to the 1.2.0 milestone Dec 15, 2019
@gwenneg gwenneg deleted the issue-6127-jdk11-graalvm-bootloader-loadclassornull-npe branch December 15, 2019 12:57
@gwenneg
Copy link
Member Author

gwenneg commented Dec 15, 2019

@gsmet Yes, I'll take care of it.

@gwenneg
Copy link
Member Author

gwenneg commented Dec 15, 2019

Issue created: #6179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

env/graalvm-java11 Relating to using GraalVM native image generation on Java 11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BootLoader.loadClassOrNull() NPE during native tests execution with JDK 11

4 participants