-
Notifications
You must be signed in to change notification settings - Fork 3k
Substitute BootLoader.loadClassOrNull(name) to fix a NPE with JDK 11 #6169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substitute BootLoader.loadClassOrNull(name) to fix a NPE with JDK 11 #6169
Conversation
5e82e38
to
19adf1a
Compare
The GraalVM issue seems to be fixed, but I got two
|
@gwenneg the PR seems to be OK now, did you just restart the tests? |
The |
OK cool, thanks for the info @gwenneg |
I found one native build error unrelated to this PR, I'll check if there's already an issue opened about it and create a new one if not. This PR is ready to be reviewed and merged. |
It looks perfectly reasonable to me but I haven't been following the latest GraalVM developments so I'll let others review and merge |
On a slightly unrelated note, I think we will need a issue created to rollback/undo some of these Graal VM fixes within our Quarkus code, once these fixes come in directly from Graal VM 19.3.1 (or better still a CR of 19.3.1) release. |
@gwenneg can you open an issue with the list of the PRs that we will need to revert? Thanks! |
@gsmet Yes, I'll take care of it. |
Issue created: #6179 |
Fixes #6127
I'm submitting this as a draft to see if CI is happy with is (even if there's no reason it wouldn't). In the meantine, I'm just starting a full JDK 11 Quarkus native build locally to make sure the exception is gone for good and see if there's anything left to fix apart from the
ConcurrentModificationException
.