Close connection in flyway tests #6036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Dec 9, 2019
| // expected fake_existing_tbl does not exist | ||
| } | ||
| } finally { | ||
| connection.close(); |
There was a problem hiding this comment.
Maybe we should use a try with resources for this, too?
There was a problem hiding this comment.
ok, I will change it to this approach: try (Connection connection = defaultDataSource.getConnection(); Statement stat = connection.createStatement()) {
gsmet
approved these changes
Dec 9, 2019
|
Good catch, thanks. |
gsmet
added
the
triage/waiting-for-ci
gastaldi
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close connection in flyway tests