Remove unused "libDir" param #5723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5683
The
BuildMojono longer uses thelibDirparam. The Mojos now all seem to use the (configured) build directory as the root for any sub-directories it wants to resolve, likeclasses,libetc...The commit here removes this unused param.
Note that although this was unusued internally, it was still advertized as a valid parameter configurable for the
quarkus-maven-plugin. So I'm marking this as a backward incompatible change.Also adding a backport tag to see if we want this included in
1.0.0to reduce the chances of this param being used by users.