Skip to content

Conversation

Karm
Copy link
Member

@Karm Karm commented Nov 22, 2019

The class FormAuthCookiesTestCase will receive additional work, mostly cookie value rotation, time out etc.

Fixes #5689

…tp package

The class FormAuthCookiesTestCase will receive additional work, mostly cookie value rotation, time out etc.

Fixes quarkusio#5689
}
FormAuthConfig form = buildTimeConfig.auth.form;
loginManager = new PersistentLoginManager(key, "quarkus-credential", form.timeout.toMillis(),
loginManager = new PersistentLoginManager(key, form.cookieName, form.timeout.toMillis(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi added backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 22, 2019
@gastaldi gastaldi added this to the 1.1.0 milestone Nov 22, 2019
@cescoffier cescoffier changed the title Fixes 5689, adds FormAuth smoke test to Elytron package and Vert.x ht… adds FormAuth smoke test to Elytron package and Vert.x ht… Nov 23, 2019
@cescoffier cescoffier changed the title adds FormAuth smoke test to Elytron package and Vert.x ht… adds FormAuth smoke test to Elytron package and Vert.x http package Nov 23, 2019
@machi1990 machi1990 merged commit 8ff09bd into quarkusio:master Nov 23, 2019
@machi1990
Copy link
Member

machi1990 commented Nov 23, 2019

Merged, thanks @Karm @gastaldi

@gsmet gsmet changed the title adds FormAuth smoke test to Elytron package and Vert.x http package Add FormAuth smoke test to Elytron package and Vert.x http package Nov 24, 2019
@gsmet gsmet removed the backport? label Nov 24, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quarkus.http.auth.form.cookie-name is actually not configurable

4 participants