Skip to content

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Nov 19, 2019

No description provided.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a minor typo and force pushed.

CI complained but I don't know why, I'm running a local build to check everything is OK.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 19, 2019
@FroMage
Copy link
Member Author

FroMage commented Nov 19, 2019

Huh, does it check javadoc?

@gsmet
Copy link
Member

gsmet commented Nov 19, 2019

Yeah there was a formatting issue in the Javadoc. I force pushed a fix.

@FroMage
Copy link
Member Author

FroMage commented Nov 19, 2019

Ah sorry I forgot about the formatter :(

@gsmet
Copy link
Member

gsmet commented Nov 19, 2019

I'll merge and backport as soon as CI is green.

@gsmet gsmet merged commit d501a4e into quarkusio:master Nov 19, 2019
@gsmet gsmet removed the backport? label Nov 19, 2019
@gsmet gsmet added this to the 1.0.0.Final milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants