Terminate request scope before sending JAX-RS response #5573
+43
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stuartwdouglas is this something I should backport? |
|
Assuming it fixes the TCK problems (which I am pretty sure it will) then yes. |
stuartwdouglas
force-pushed
the
span-ordering
branch
2 times, most recently
from
5418163 to
5ab0b96
Compare
This gives more consistent span ordering for Opentracing
stuartwdouglas
force-pushed
the
span-ordering
branch
from
5ab0b96 to
6a4c53d
Compare
|
I think this will fix the tck issue. The problems are Racey though but I think this will fix it |
gsmet
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives more consistent span ordering for Opentracing
Fixes #5569