update amazon-lambda-archetype to provide SAM templates #5570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
reviewed
Nov 20, 2019
|
I am grossly underqualified to review this since I don't know much of anything about amazon lambda :) |
|
it's mostly just the textual changes (not strictly amazon-related) that I wanted a newbie's eye on. And the two of you reviewed the last round so i figured I'd give it another shot. @oztimpower has verified the template changes, fwiw. |
|
Sure, I'll go over the text, no problem |
geoand
reviewed
Nov 20, 2019
geoand
reviewed
Nov 20, 2019
geoand
reviewed
Nov 20, 2019
geoand
reviewed
Nov 20, 2019
|
@evanchooly can you squash everything once you're done? Thanks! |
|
@gsmet for sure. |
merge helper scripts to one file and parameterize it to reduce clutter and repetition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge helper scripts to one file and parameterize it to reduce clutter and repetition
fixes #5037