Replacing quarkus.properties with quarkus.platform.version #5564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloubyansky
added
the
area/platform
maxandersen
reviewed
Nov 18, 2019
independent-projects/tools/common/src/test/java/io/quarkus/cli/commands/ListExtensionsTest.java
Show resolved
Hide resolved
maxandersen
reviewed
Nov 18, 2019
core/deployment/src/main/java/io/quarkus/deployment/configuration/ConfigDefinition.java
Outdated
Show resolved
Hide resolved
maxandersen
requested changes
Nov 18, 2019
dmlloyd
reviewed
Nov 18, 2019
| QUARKUS_NAMESPACE + ".platform.group-id", | ||
| QUARKUS_NAMESPACE + ".platform.artifact-id", | ||
| QUARKUS_NAMESPACE + ".platform.version", | ||
| QUARKUS_NAMESPACE + "-plugin.version", |
There was a problem hiding this comment.
I'm pretty sure that this entry isn't needed. The config subsystem should only warn on properties whose name starts with quarkus.
There was a problem hiding this comment.
Ok, removing it from here. Thanks.
aloubyansky
force-pushed
the
4744
branch
2 times, most recently
from
a0fb26c to
b6a5f4a
Compare
maxandersen
approved these changes
Nov 18, 2019
aloubyansky
force-pushed
the
4744
branch
2 times, most recently
from
c461f4f to
3766fed
Compare
…quarkus.platform.version and quarkus-plugin.version for Maven and quarkusVersion with quarkusPluginVersion for Gradle, also adding quarkus.platform.group-is and quarkus.platform.artifact-id to pom.xml templates and sorting of properties before persisting pom.xml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and quarkus-plugin.version in Maven templates and quarkusVersion with quarkusPluginVersion in the Gradle ones, also adding quarkus.platform.group-is and quarkus.platform.artifact-id to pom.xml templates and sorting of properties before persisting pom.xml.
Fixes #4744