Skip to content

close handlers and free all associated resources. #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2019
Merged

close handlers and free all associated resources. #5535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
<maven-invoker.version>3.0.1</maven-invoker.version>
<awaitility.version>4.0.1</awaitility.version>
<jprocesses.version>1.6.5</jprocesses.version>
<jboss-logmanager.version>1.0.3</jboss-logmanager.version>
<jboss-logmanager.version>1.0.4</jboss-logmanager.version>
<jgit.version>5.5.1.201910021850-r</jgit.version>
<jetty.version>9.4.19.v20190610</jetty.version>
<flyway.version>6.0.6</flyway.version>
Expand Down
14 changes: 14 additions & 0 deletions core/runtime/src/main/java/io/quarkus/runtime/Timing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
package io.quarkus.runtime;

import java.math.BigDecimal;
import java.util.logging.Handler;

import org.jboss.logging.Logger;

import io.quarkus.runtime.logging.InitialConfigurator;

/**
* Class that is responsible for printing out timing results.
* <p>
Expand Down Expand Up @@ -79,6 +82,17 @@ public static void printStopTime(String name) {
(UNSET_VALUE.equals(name) || name == null || name.trim().isEmpty()) ? "Quarkus" : name,
secondsRepresentation);
bootStopTime = -1;

/**
* We can safely close log handlers after stop time has been printed.
*/
Handler[] handlers = InitialConfigurator.DELAYED_HANDLER.clearHandlers();
for (Handler handler : handlers) {
try {
handler.close();
} catch (Throwable ignored) {
}
}
}

public static BigDecimal convertToBigDecimalSeconds(final long timeNanoSeconds) {
Expand Down