Explicitly disable the clustering on the web Vert.x instance. #5518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix quarkusio#5240. Note that again, clustering is only supported in JVM mode and requires a cluster manager in the classpath.
|
|
||
| if (allowClustering) { | ||
| // Order matters, as the cluster options modifies the event bus options. | ||
| setEventBusOptions(conf, options); |
There was a problem hiding this comment.
Even if there is no clustering shouldn't we still set the event bus options?
There was a problem hiding this comment.
@cescoffier told me they were all related to the clustering.
@cescoffier are we sure it will always be the case and there won't be event bus options not-clustering related?
There was a problem hiding this comment.
Yes, all the event bus options are related to clustering (SSL, TCP options and so on)
gsmet
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5240.
Note that again, clustering is only supported in JVM mode and requires a cluster manager in the classpath.