Skip to content

Conversation

xfh
Copy link
Contributor

@xfh xfh commented Nov 15, 2019

To generate the static metamodel, e.g. for criteria queries, the
hibernate-jpamodelgen dependency must be added.

Adding the dependency in the dependency management section of the
bom makes it easier to keep the versions of hibernate and the
metamodel generator in sync.

Each project using the metamodel still needs to add an explicit
dependency as in

<dependencies>
   ...
    <dependency>
        <groupId>org.hibernate</groupId>
        <artifactId>hibernate-jpamodelgen</artifactId>
    </dependency>
</dependencies>

To generate the static metamodel, e.g. for criteria queries, the
hibernate-jpamodelgen dependency must be added to the classpath.

Adding the dependency in the dependency management section of the
bom makes it easier to keep the versions of hibernate and the
metamodel generator in sync.
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed a good idea. Thanks for that!

@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes backport? labels Nov 15, 2019
@machi1990
Copy link
Member

CI failure looks totally unrelated with the change

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0-jboss-2:testCompile (default-testCompile) on project quarkus-integration-test-vertx-http: Compilation failure
[ERROR] /home/vsts/work/1/s/integration-tests/vertx-http/src/test/java/io/quarkus/it/vertx/VertxProducerResourceTest.java:[21,29] cannot find symbol
[ERROR]   symbol:   method ssl()
[ERROR]   location: @interface io.quarkus.test.common.http.TestHTTPResource
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
The process '/usr/share/apache-maven-3.6.1/bin/mvn' failed with exit code 1
Could not retrieve code analysis results - Maven run failed.

@gsmet gsmet merged commit 7619f75 into quarkusio:master Nov 15, 2019
@gsmet gsmet removed the backport? label Nov 15, 2019
@gsmet gsmet added this to the 1.0.0.Final milestone Nov 15, 2019
xfh added a commit to dvbern/kibon-exchange-service that referenced this pull request Nov 21, 2019
The version synchronisation will be resolved by
quarkusio/quarkus#5515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants