Skip to content

Conversation

stuartwdouglas
Copy link
Collaborator

This is no longer needed after the changes in how challenges are handled.

Partial fix for #5419

@stuartwdouglas
Copy link
Collaborator Author

@gsmet FYI

@geoand
Copy link
Contributor

geoand commented Nov 15, 2019

The test failure seems related

@stuartwdouglas stuartwdouglas force-pushed the rest-servlet-auth branch 4 times, most recently from 698be0c to 9411789 Compare November 18, 2019 04:34
@sberyozkin sberyozkin self-requested a review November 18, 2019 10:26
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sberyozkin sberyozkin self-requested a review November 18, 2019 10:35
@gsmet gsmet force-pushed the rest-servlet-auth branch from 9411789 to 989ba4a Compare November 18, 2019 16:14
@gsmet
Copy link
Member

gsmet commented Nov 18, 2019

I rebased it as the first commit was included in another PR.

This is no longer needed after the changes in how challenges are handled.

Partial fix for quarkusio#5419
@gsmet gsmet force-pushed the rest-servlet-auth branch from 989ba4a to fcbcde3 Compare November 19, 2019 11:55
@gsmet
Copy link
Member

gsmet commented Nov 19, 2019

I just rebased and force-pushed.

@gsmet gsmet merged commit 9c837f2 into quarkusio:master Nov 19, 2019
@gsmet gsmet added this to the 1.0.0.Final milestone Nov 19, 2019
@gsmet gsmet removed the backport? label Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants