Skip to content

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Nov 14, 2019

Fixes #4377 (Among various other fixes from upstream ORM)

@Sanne Sanne requested a review from gsmet November 14, 2019 21:34
@geoand
Copy link
Contributor

geoand commented Nov 15, 2019

This needs to be rebased onto the latest master for same reason that I have described in chat: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Hibernate.20validator.20IT.20issue.3F

@Sanne
Copy link
Member Author

Sanne commented Nov 15, 2019

I didn't understand the reason :) but rebased and crossing fingers ...

@geoand
Copy link
Contributor

geoand commented Nov 15, 2019

CI leaks artifacts in native unfortunately... I have seen in plenty of times and it's most evident when there are a lot of PRs.

I'm willing to bet that the tests will pass with your rebase :)

@Sanne
Copy link
Member Author

Sanne commented Nov 15, 2019

So there was a native test failure before my latest push?

Unfortunately I rebased before looking, didn't think the link to CI reports would be lost.

@geoand
Copy link
Contributor

geoand commented Nov 15, 2019

There was a native test failure in a module totally unrelated to your PR.
Unfortunately this has happened in the past plenty of times and as I explain the chat thread I linked it's most likely either a misuse on our part of Azure Pipeline's caching, or a bug in the CI solution itself

@Sanne
Copy link
Member Author

Sanne commented Nov 15, 2019

ok got it. Thanks I was worried, I tested it all locally but stuff changes so fast here :)

@geoand
Copy link
Contributor

geoand commented Nov 15, 2019

Supersonic changes 🚀

@Sanne Sanne merged commit 3d5bbbd into quarkusio:master Nov 15, 2019
@Sanne Sanne deleted the ORMUpdate branch November 15, 2019 11:26
@gsmet gsmet added this to the 1.1.0 milestone Nov 15, 2019
@gsmet gsmet removed the backport? label Nov 15, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hibernate - @ManyToOne strange behavior

4 participants