Skip to content

Support repeatable QuarkusTestResource annotation #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

Support repeatable QuarkusTestResource annotation #5273

merged 1 commit into from
Nov 7, 2019

Conversation

@mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 7, 2019

Thanks @gastaldi for the the test! ;-)

@mkouba mkouba added this to the 1.0.0.Final milestone Nov 7, 2019
@mkouba mkouba requested review from gastaldi and gsmet November 7, 2019 08:06
@gwenneg gwenneg merged commit 980f67b into quarkusio:master Nov 7, 2019
@gwenneg
Copy link
Member

gwenneg commented Nov 7, 2019

@mkouba Is 1.0.0.Final the right milestone for this PR? I've seen a lot of PR associated with 1.1.0 lately but I'm not sure this is the good one either :)

@gwenneg
Copy link
Member

gwenneg commented Nov 7, 2019

cc @gsmet ^

@gsmet gsmet modified the milestones: 1.0.0.Final, 1.1.0 Nov 7, 2019
@gsmet
Copy link
Member

gsmet commented Nov 7, 2019

It should be 1.1.0 and have the backport? tag. Master is 1.1.0, we have a 1.0 branch where I will backport the issues myself.

@gwenneg gwenneg mentioned this pull request Nov 8, 2019
Merged
@gsmet gsmet removed the backport? label Nov 14, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 14, 2019
@CVeniamin CVeniamin mentioned this pull request Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gwenneg gwenneg gwenneg approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees

No one assigned

Labels

area/testing

Projects

None yet

Milestone

1.0.0.CR2

Development

Successfully merging this pull request may close these issues.

4 participants

@mkouba @gwenneg @gsmet @gastaldi