Skip to content

Update to GraalVM SDK 19.2.1 #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2019
Merged

Update to GraalVM SDK 19.2.1 #5189

merged 2 commits into from
Nov 5, 2019

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 4, 2019

The artifacts finally got released on Central.

@gsmet
Update to GraalVM SDK 19.2.1
a29267b 
The artifacts finally got released on Central.
machi1990
machi1990 reviewed Nov 4, 2019
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we also update the message in here

quarkus/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

Lines 304 to 307 in fc51029

if (vmVersionIsObsolete) {
log.error("Out of date build of GraalVM detected! Please upgrade to GraalVM 19.2.0.");
return true;
}
?

@gsmet gsmet added the backport? label Nov 5, 2019
@cescoffier cescoffier added this to the 0.29.0 milestone Nov 5, 2019
@gsmet
Copy link
Member Author

gsmet commented Nov 5, 2019

Good catch, @machi1990

@cescoffier cescoffier merged commit 8f12f48 into quarkusio:master Nov 5, 2019
@gsmet gsmet removed the backport? label Nov 5, 2019
@gsmet gsmet modified the milestones: 0.29.0, 0.28.2 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cescoffier cescoffier cescoffier approved these changes

+1 more reviewer

@machi1990 machi1990 machi1990 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0.CR1

Development

Successfully merging this pull request may close these issues.

3 participants

@gsmet @cescoffier @machi1990