Also configure the Surefire plugin in the Maven IT #5162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxandersen
approved these changes
Nov 4, 2019
|
I don't understand your comment. It's happening for a very good reason: we are building in a totally isolated Maven repo so we need the whole Maven build to point to it. Right now, we build 0.28.0 in this isolated repository and then the tests are run against the default repo where the current released version is not available. |
gsmet
force-pushed
the
fix-surefire-conf-maven-it
branch
from
75a62ef to
3501b72
Compare
|
my comment was that I assumed we were doing this by using a ~/.m2/settings.xml file which everything in the chain should listen to but from our conversation on zulip sounds like its done via property/env variables instead so when tests are forking things doesn't work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we can't build the release as the tests do not point to the locally configured repository and the platform cannot resolve the bom.