Don't log IOException at ERROR #5151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
added
the
triage/waiting-for-ci
|
It looks like there's a formatting issue. |
It is very normal for connections to be termianted by the remote client (e.g. hitting the cancel button in firefox). There is nothing we can do about these errors so they should be logged at debug. Logging at a higher level opens up the possibility of a DOS attack, as any client can trigger an excessive amount of logging by sending a request then immediatly closing the connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very normal for connections to be termianted by the remote
client (e.g. hitting the cancel button in firefox). There is nothing
we can do about these errors so they should be logged at debug.
Logging at a higher level opens up the possibility of a DOS attack,
as any client can trigger an excessive amount of logging by sending
a request then immediatly closing the connection.