Skip to content

Fix unclosed InputStreams #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2019
Merged

Fix unclosed InputStreams #5132

merged 1 commit into from
Nov 3, 2019

Conversation

gwenneg
Copy link
Member

@gwenneg gwenneg commented Nov 2, 2019

No description provided.

@gwenneg gwenneg force-pushed the inputstream-try-with-resources branch from d0b4dda to 6b72b2d Compare November 2, 2019 23:44
@gwenneg gwenneg changed the title Ensure InputStreams are closed using try-with-resources Fix unclosed InputStreams Nov 2, 2019
@gwenneg gwenneg force-pushed the inputstream-try-with-resources branch from 6b72b2d to 14d3c37 Compare November 2, 2019 23:49
gastaldi
gastaldi approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good catch!

@gsmet gsmet merged commit 274cfa3 into quarkusio:master Nov 3, 2019
@gsmet
Copy link
Member

gsmet commented Nov 3, 2019

Thanks!

@gsmet gsmet added this to the 0.28.0 milestone Nov 3, 2019
@gwenneg gwenneg deleted the inputstream-try-with-resources branch November 3, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gwenneg @gsmet @gastaldi