Ensure @ConfigProperties validation works in native mode #5122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
force-pushed
the
configproperties-native
branch
from
97ad9e9 to
4bff7c5
Compare
gsmet
reviewed
Nov 1, 2019
core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java
Outdated
Show resolved
Hide resolved
extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java
Show resolved
Hide resolved
gsmet
approved these changes
Nov 1, 2019
geoand
added
the
triage/waiting-for-ci
geoand
force-pushed
the
configproperties-native
branch
from
4bff7c5 to
aa1f2ba
Compare
|
Merged, thanks! |
|
Thank you! |
|
@geoand Looks good. So IIUIC the problem was that for |
|
Exactly yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.