Bean that has a bound interceptor must not declare final methods #5108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ach, "Imports are not sorted..." again... |
manovotn
approved these changes
Nov 1, 2019
|
Is it supposed to replace #5104 ? |
|
No, it's a prerequisite. I have rebased that PR onto this one locally so once this one is ready, I'll force push the to #5104 |
mkouba
force-pushed
the
subclass-disallow-final-methods
branch
from
23434e9 to
46232cd
Compare
gsmet
reviewed
Nov 1, 2019
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanInfo.java
Outdated
Show resolved
Hide resolved
mkouba
force-pushed
the
subclass-disallow-final-methods
branch
2 times, most recently
from
ebf00ee to
4951446
Compare
|
@gsmet added |
gsmet
approved these changes
Nov 1, 2019
gsmet
added
the
triage/waiting-for-ci
|
|
|
Imports again :P |
|
Eh, I need to import more coffee. Or maybe start doing something meaningful ;-). |
- otherwise a deployment exception is thrown - final methods declared on bean classes that require client proxies are ignored though
mkouba
force-pushed
the
subclass-disallow-final-methods
branch
from
4951446 to
e08e3d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignored though