Skip to content

ComponentsProviderGenerator - break getComponents into multiple methods #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2019
Merged

ComponentsProviderGenerator - break getComponents into multiple methods #5077

merged 1 commit into from
Oct 31, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 31, 2019

@mkouba mkouba added this to the 0.28.0 milestone Oct 31, 2019
@stuartwdouglas stuartwdouglas merged commit 4d16d85 into quarkusio:master Oct 31, 2019
manovotn
manovotn reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I am coming late but I did review it nonetheless.
It's a really good solution and as a side effect, it makes the generated class more readable IMO.
Let's see if someone can breach the method limit with that ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manovotn manovotn manovotn left review comments

+1 more reviewer

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.28.0

Development

Successfully merging this pull request may close these issues.

ComponentsProviderGenerator - break the generated getComponents() method for large deployments into multiple methods

4 participants

@mkouba @stuartwdouglas @manovotn @gsmet