CORS headers may not be sent on 403 #5056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Oct 30, 2019
gastaldi
added
component:new-http
triage/waiting-for-ci
gsmet
approved these changes
Oct 30, 2019
gastaldi
reviewed
Oct 30, 2019
|
|
||
| //predefined system priorities | ||
| public static final int AUTHENTICATION = 200; | ||
| public static final int CORS = 150; |
There was a problem hiding this comment.
CORS should take precedence over AUTHENTICATION and AUTHORIZATION since the credentials may be wrong
The authorization and CORS handlers had the same priority, which means sometimes CORS headers would not be sent on a 403 response.
stuartwdouglas
force-pushed
the
cors-perms
branch
from
716e541 to
1da0103
Compare
This was referenced Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authorization and CORS handlers had the same priority,
which means sometimes CORS headers would not be sent on a
403 response.