Skip to content

Conversation

Aryant-Tripathi
Copy link
Contributor

@Aryant-Tripathi Aryant-Tripathi commented Oct 7, 2025

Consistently apply @ Named and @PersistenceUnit qualifiers to Hibernate ORM beans

Fixes #50138

Previously, the @ Named and @PersistenceUnit qualifiers were added conditionally to Hibernate ORM beans. This change ensures that both qualifiers are always applied for every persistence unit, aligning the behavior with Hibernate Search and improving consistency and CDI injection reliability across the codebase.

Tests are updated to confirm that beans are correctly qualified and injected for each persistence unit.

Copy link

quarkus-bot bot commented Oct 7, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should count at least 2 words to describe the change properly
  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Oct 7, 2025
Copy link

quarkus-bot bot commented Oct 7, 2025

/cc @gsmet (hibernate-orm)

Consistently apply @nAmed and @PersistenceUnit qualifiers to Hibernate ORM beans

Fixes quarkusio#50138

Previously, the @nAmed and @PersistenceUnit qualifiers were added conditionally to Hibernate ORM beans. This change ensures that both qualifiers are always applied for every persistence unit, aligning the behavior with Hibernate Search and improving consistency and CDI injection reliability across the codebase.

Tests are updated to confirm that beans are correctly qualified and injected for each persistence unit.
@Aryant-Tripathi Aryant-Tripathi force-pushed the issue-50138-hibernate-orm-named-qualifier branch from e167e57 to e80fea1 Compare October 7, 2025 19:21
@yrodiere yrodiere requested a review from marko-bekhta October 8, 2025 07:57
…te ORM beans

- Previously, the @ Named and @PersistenceUnit qualifiers were added conditionally to Hibernate ORM beans. This change ensures that both qualifiers are always applied for every persistence unit, aligning the behavior with Hibernate Search and improving consistency and CDI injection reliability across the codebase.
- Tests are updated to confirm that beans are correctly qualified and injected for each persistence unit.
- Fixes quarkusio#50138
@yrodiere
Copy link
Member

yrodiere commented Oct 9, 2025

LGTM, thank you. Let's see if CI agrees.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 9, 2025
Copy link

quarkus-bot bot commented Oct 9, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b23f378.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit c6104f8 into quarkusio:main Oct 13, 2025
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Oct 13, 2025
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be more consistent about the CDI qualifiers we apply to Hibernate Search/ORM beans

3 participants