Skip to content

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Oct 7, 2025

Cleanup/simplification in core module

3 commits covering:

  • For loops simplification
  • Files.writeString instead of Files.write
  • Pattern variable usage with instanceOf
    • BytecodeRecorderImpl has also several cases of instanceOf usage, but I didn't touch it not to impact possible backports into LTS branches

This comment has been minimized.

Copy link

github-actions bot commented Oct 7, 2025

🎊 PR Preview f72af1e has been successfully built and deployed to https://quarkus-pr-main-50448-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

This comment has been minimized.

@rsvoboda rsvoboda force-pushed the cleanup-2025-10-07 branch from 177a06e to 4661cdd Compare October 8, 2025 12:38
@rsvoboda
Copy link
Member Author

rsvoboda commented Oct 8, 2025

Rebased to resolve conflict with 4557b4a

private static void toHex(byte[] digest, StringBuilder sb) {
for (int i = 0; i < digest.length; ++i) {
sb.append(Integer.toHexString((digest[i] & 0xFF) | 0x100), 1, 3);
for (byte b : digest) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this one I checked and I think it should be fine.

Copy link

quarkus-bot bot commented Oct 8, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 4661cdd.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Oct 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4661cdd.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 25

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$1(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni(MicrometerTimedInterceptorTest.java:174)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:534)

⚙️ JVM Tests - JDK 17 Windows

📦 test-framework/junit5-internal

io.quarkus.test.QuarkusProdModeTestConfusingLogTest.shouldWaitForAppActuallyStarted - History

  • App's HTTP server is not reachable ==> Unexpected exception thrown: java.net.http.HttpConnectTimeoutException: HTTP connect timed out - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: App's HTTP server is not reachable ==> Unexpected exception thrown: java.net.http.HttpConnectTimeoutException: HTTP connect timed out
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152)
	at org.junit.jupiter.api.AssertDoesNotThrow.createAssertionFailedError(AssertDoesNotThrow.java:84)
	at org.junit.jupiter.api.AssertDoesNotThrow.assertDoesNotThrow(AssertDoesNotThrow.java:53)
	at org.junit.jupiter.api.AssertDoesNotThrow.assertDoesNotThrow(AssertDoesNotThrow.java:40)
	at org.junit.jupiter.api.Assertions.assertDoesNotThrow(Assertions.java:3218)
	at io.quarkus.test.QuarkusProdModeTestConfusingLogTest.thenAppIsRunning(QuarkusProdModeTestConfusingLogTest.java:73)
	at io.quarkus.test.QuarkusProdModeTestConfusingLogTest.shouldWaitForAppActuallyStarted(QuarkusProdModeTestConfusingLogTest.java:49)

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

  • Too many recursions, message not returned for id [678426026] - java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [678426026]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:175)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)

@gastaldi gastaldi merged commit b1c03c7 into quarkusio:main Oct 8, 2025
61 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants